Remove .git from .dockerignore #1964
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e and testing will not starting at all Signed-off-by: Laszlo Meszaros <lacienator@gmail.com>
lmesz
force-pushed
the
fix_pre-commit_and_test_execution
branch
from
9fa3f54 to
f50f163
Compare
|
And that fix was just merged, so you should be all set. Let me know if you have any problems with the new master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I have read the guideline how to contribute to compose, but when I tried to execute tests, pre-commit failed. So tests didn't have chance to run at all.
This was because tests run in a container in which the code was added but .git directory was on the exclude list, but pre-commit needs it.