Ensure RefResolver works across operating systems #2068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnowster
force-pushed
the
2037-jsonschema-resolver-windows-path-fix
branch
3 times, most recently
from
06b5a23 to
1c93cc7
Compare
mnowster
changed the title
mnowster
force-pushed
the
2037-jsonschema-resolver-windows-path-fix
branch
from
1c93cc7 to
85265be
Compare
Slashes, paths and a tale of woe. Validation now works on windows \o/ Signed-off-by: Mazz Mosley <mazz@houseofmnowster.com>
mnowster
force-pushed
the
2037-jsonschema-resolver-windows-path-fix
branch
from
85265be to
5509990
Compare
|
|
aanand
added a commit
that referenced
this pull request
Sep 18, 2015
…ws-path-fix Ensure RefResolver works across operating systems
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way paths were being done previously to load the schema meant they weren't working on windows, which meant the RefResolver couldn't find the *schema.json files to load in for successful validation.
Fixes #2037