Added support for cgroup_parent #2112
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mohit Soni <mosoni@paypal.com>
If we get back an error that wasn't an APIError, it was causing the thread to hang. This catch all, while I appreciate feels risky to have a catch all, is better than not catching and silently failing, with a never ending thread. If something worse than an APIError has gone wrong, we want to stop the incredible journey of what we're doing. Signed-off-by: Mazz Mosley <mazz@houseofmnowster.com>
Signed-off-by: mhor <maxime.horcholle@gmail.com>
Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
… exist. Fixes #1826 Signed-off-by: Karol Duleba <mr.fuxi@gmail.com>
To align with the docker/docker repo. Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
Signed-off-by: Ben Hamill <git-commits@benhamill.com>
Signed-off-by: Karol Duleba <mr.fuxi@gmail.com>
In order to validate a service name that has been specified as an integer we need to run that as a pre-process validation step *before* we pass the config to be validated against the schema. It is not possible to validate it *in* the schema, it causes a type error. Even though a number is a valid service name, it must be a cast as a string within the yaml to avoid type error. Taken this opportunity to move the code design in a direction towards: 1. pre-process 2. validate 3. construct Signed-off-by: Mazz Mosley <mazz@houseofmnowster.com>
Signed-off-by: Joel Hansson <joel.hansson@ecraft.com>
Signed-off-by: Joel Hansson <joel.hansson@ecraft.com>
Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
Signed-off-by: Frank Sachsenheim <funkyfuture@riseup.net>
Signed-off-by: Frank Sachsenheim <funkyfuture@riseup.net>
Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
In particular it includes: - some extension of CONTRIBUTING.md - one fix for Python 2.6 in tests/integration/cli_test.py - one fix for Python 3.3 in tests/integration/service_test.py - removal of unused imports Make stream_output Python 3-compatible Signed-off-by: Frank Sachsenheim <funkyfuture@riseup.net>
… for py2 and py3. Signed-off-by: Daniel Nephin <dnephin@gmail.com>
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
…r-py response. Signed-off-by: Daniel Nephin <dnephin@gmail.com>
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
Signed-off-by: Daniel Nephin <dnephin@docker.com>
Signed-off-by: Daniel Nephin <dnephin@docker.com>
Signed-off-by: Daniel Nephin <dnephin@docker.com>
…nfig doesn't import from cli. Signed-off-by: Daniel Nephin <dnephin@docker.com>
Signed-off-by: Daniel Nephin <dnephin@docker.com>
Signed-off-by: Daniel Nephin <dnephin@docker.com>
Signed-off-by: Daniel Nephin <dnephin@docker.com>
Signed-off-by: Daniel Nephin <dnephin@docker.com>
Signed-off-by: Daniel Nephin <dnephin@docker.com>
Signed-off-by: Steve Durrheimer <s.durrheimer@gmail.com>
Signed-off-by: Steve Durrheimer <steve.durrheimer@netapsys.fr>
Signed-off-by: Daniel Nephin <dnephin@docker.com>
Signed-off-by: Harald Albers <github@albersweb.de>
Signed-off-by: Vojta Orgon <villlem@gmail.com>
Bring in line with Glossary. https://docs.docker.com/reference/glossary/ Alphabetising list makes makes parsing by humans easier. Signed-off-by: Mike Bailey <mike.bailey@rea-group.com> Conflicts: docs/yml.md
Signed-off-by: Mazz Mosley <mazz@houseofmnowster.com>
Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
Signed-off-by: Lucas N. Munhoz <ln.munhoz@gmail.com>
Signed-off-by: Mary Anthony <mary@docker.com>
Signed-off-by: Daniel Nephin <dnephin@docker.com>
Signed-off-by: Daniel Nephin <dnephin@docker.com>
Signed-off-by: Daniel Nephin <dnephin@docker.com>
Signed-off-by: Daniel Nephin <dnephin@docker.com>
Signed-off-by: Daniel Nephin <dnephin@docker.com>
Author
|
I think I did something wrong during rebase. Let me work on figuring out how to fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds cgroup-parent support to compose project. It allows each service to specify a 'cgroup_parent' option.
Related: