Skip to content

Conversation

@dnephin
Copy link

@dnephin dnephin commented Oct 8, 2015

DON'T MERGE

Opening a PR to make sure I haven't missed anything, and as an FYI so we don't duplicate the effort.

CHANGELOG.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To prevent these links to break in future, consider linking to a specific commit, or to the document in the release branch/tag

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally I'd like to link to a tag, but we don't create the tag until after the official release, so anyone reading these as part of an rc won't get a correct link.

I also can't link to a branch because we'll drop the bump-1.5.0 branch after release.

I guess that only leaves a commit, which is an ugly URL, but not sure what else to do

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point :/

Perhaps leave it like this during the RC period, and update together with the bump?
Is there a tag created for the RC's?

@dnephin dnephin force-pushed the release_notes_1.5.0 branch from 0d41e77 to a5ffee3 Compare October 13, 2015 19:31
CHANGELOG.md Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth sticking this at the bottom, clarifying that it's an experimental feature - it might confuse users if they think this is the default. (How does this work? Do I have to change what I'm doing? etc)

@dnephin dnephin force-pushed the release_notes_1.5.0 branch 2 times, most recently from a951651 to bd8fb79 Compare October 13, 2015 19:36
Signed-off-by: Daniel Nephin <dnephin@docker.com>
@dnephin
Copy link
Author

dnephin commented Oct 13, 2015

Updated based on feedback

@dnephin dnephin closed this Oct 15, 2015
@dnephin dnephin deleted the release_notes_1.5.0 branch October 15, 2015 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants