Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions compose/config/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
DOCKER_CONFIG_KEYS = [
'cap_add',
'cap_drop',
'cgroup_parent',
'command',
'cpu_shares',
'cpuset',
Expand Down
1 change: 1 addition & 0 deletions compose/config/fields_schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
"build": {"type": "string"},
"cap_add": {"type": "array", "items": {"type": "string"}, "uniqueItems": true},
"cap_drop": {"type": "array", "items": {"type": "string"}, "uniqueItems": true},
"cgroup_parent": {"type": "string"},
"command": {
"oneOf": [
{"type": "string"},
Expand Down
5 changes: 4 additions & 1 deletion compose/service.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
DOCKER_START_KEYS = [
'cap_add',
'cap_drop',
'cgroup_parent',
'devices',
'dns',
'dns_search',
Expand Down Expand Up @@ -675,6 +676,7 @@ def _get_container_host_config(self, override_options, one_off=False):
read_only = options.get('read_only', None)

devices = options.get('devices', None)
cgroup_parent = options.get('cgroup_parent', None)

return self.client.create_host_config(
links=self._get_links(link_to_self=one_off),
Expand All @@ -696,7 +698,8 @@ def _get_container_host_config(self, override_options, one_off=False):
read_only=read_only,
pid_mode=pid,
security_opt=security_opt,
ipc_mode=options.get('ipc')
ipc_mode=options.get('ipc'),
cgroup_parent=cgroup_parent
)

def build(self, no_cache=False, pull=False):
Expand Down
6 changes: 6 additions & 0 deletions docs/compose-file.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,12 @@ Override the default command.

command: bundle exec thin -p 3000

### cgroup_parent

Specify an optional parent cgroup for the container.

cgroup_parent: m-executor-abcd

### container_name

Specify a custom container name, rather than a generated default name.
Expand Down
12 changes: 12 additions & 0 deletions tests/unit/service_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,18 @@ def test_memory_swap_limit(self):
2000000000
)

def test_cgroup_parent(self):
self.mock_client.create_host_config.return_value = {}

service = Service(name='foo', image='foo', hostname='name', client=self.mock_client, cgroup_parent='test')
service._get_container_create_options({'some': 'overrides'}, 1)

self.assertTrue(self.mock_client.create_host_config.called)
self.assertEqual(
self.mock_client.create_host_config.call_args[1]['cgroup_parent'],
'test'
)

def test_log_opt(self):
self.mock_client.create_host_config.return_value = {}

Expand Down