Skip to content

Conversation

@sdurrheimer
Copy link

…ver'

Ref. #2191

ping @albers New options for docker-compose

Signed-off-by: Steve Durrheimer s.durrheimer@gmail.com

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it Experimental for Compose? Because it's out of experimental for docker itself for 1.9.

/cc @dnephin

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya, we had to make it opt-in for compose because we don't want to force every compose user to upgrade to 1.9 immediately.

@sdurrheimer sdurrheimer force-pushed the zsh-completion-network-options branch from 0f0770c to b3201fe Compare October 19, 2015 10:29
@sdurrheimer
Copy link
Author

Same as #2211 : Please schedule this for 1.5.0 as the feature is present in that release.

…ver'

Signed-off-by: Steve Durrheimer <s.durrheimer@gmail.com>
@sdurrheimer sdurrheimer force-pushed the zsh-completion-network-options branch from b3201fe to ac06366 Compare October 19, 2015 10:31
@mnowster
Copy link

LGTM

@dnephin dnephin added this to the 1.5.0 milestone Oct 19, 2015
@dnephin
Copy link

dnephin commented Oct 19, 2015

LGTM

dnephin added a commit that referenced this pull request Oct 19, 2015
Add zsh completion for 'docker-compose --x-networking --x-network-dri…
@dnephin dnephin merged commit 076b5bc into docker:master Oct 19, 2015
@thaJeztah
Copy link
Member

Thanks @sdurrheimer, great to see you working in the other repositories as well! 👍👍 👍 👍

@sdurrheimer
Copy link
Author

@thaJeztah You’re welcome ;-)

@sdurrheimer sdurrheimer deleted the zsh-completion-network-options branch November 11, 2015 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants