Add ability to remove one-off containers #3141
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shin-
force-pushed
the
2774-off-one-offs
branch
from
d0ae83b to
5e3a720
Compare
compose/cli/main.py
Outdated
| Options: | ||
| -f, --force Don't ask to confirm removal | ||
| -v Remove volumes associated with containers | ||
| -a, --all Also remove one-off containers |
There was a problem hiding this comment.
I wonder if users know what "one-off" containers are, or if we should add "one-off containers created by docker-compose run".
Signed-off-by: Joffrey F <joffrey@docker.com>
Signed-off-by: Joffrey F <joffrey@docker.com>
shin-
force-pushed
the
2774-off-one-offs
branch
from
668fb19 to
77457a7
Compare
| def update_labels(cls, value, labels): | ||
| if value == cls.only: | ||
| labels.append('{0}={1}'.format(LABEL_ONE_OFF, "True")) | ||
| elif value == cls.exclude or value is False: |
There was a problem hiding this comment.
Why value is False here? I think it might be safer to change the existing calls.
|
Replaced by #3178 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rmcommand now accepts a--allargument (shorthand-a) to remove one-off containers as well.Going forward, the plan is to have this always be the case, hence a warning should be added for users when using
rm