Skip to content

Conversation

@jamesottaway
Copy link

This caught me out until I found #3179, so I want to avoid anyone else being confused.

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "patch-1" git@github.com:jamesottaway/compose.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

Signed-off-by: James Ottaway <git@james.ottaway.io>
@jamesottaway
Copy link
Author

I was half way through amending my commit when you commented. Props on the simple instructions for those who don't know Git very well. I've force-pushed the amended commit.

@dnephin
Copy link

dnephin commented Jun 24, 2016

LGTM

1 similar comment
@SvenDowideit
Copy link

LGTM

@SvenDowideit SvenDowideit merged commit 5c1abe2 into docker:master Jun 27, 2016
@jamesottaway jamesottaway deleted the patch-1 branch June 27, 2016 03:24
@SvenDowideit SvenDowideit added this to the 1.7.1 milestone Jul 28, 2016
SvenDowideit added a commit that referenced this pull request Jul 28, 2016
Document `tmpfs` being v2 only
(cherry picked from commit 5c1abe2)

Signed-off-by: Sven Dowideit <SvenDowideit@home.org.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants