-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Remove fig.packages replace with real deps. #375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,17 @@ | ||
| FROM ubuntu:14.04 | ||
| RUN apt-get update -qq && apt-get install -qy python python-pip python-dev | ||
| ADD requirements.txt /code/ | ||
| RUN apt-get update -qq && apt-get install -qy python python-pip python-dev git | ||
| RUN useradd -d /home/user -m -s /bin/bash user | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These are added separately so they are cached.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah, I didn't realize that worked There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yep – a few versions ago, Docker started storing the hashsum of the tarball of an ADD to detect if the contents have changed. It's pretty sweet. |
||
|
|
||
| WORKDIR /code/ | ||
|
|
||
| ADD requirements.txt /code/ | ||
| RUN pip install -r requirements.txt | ||
|
|
||
| ADD requirements-dev.txt /code/ | ||
| RUN pip install -r requirements-dev.txt | ||
|
|
||
| ADD . /code/ | ||
| RUN python setup.py develop | ||
| RUN useradd -d /home/user -m -s /bin/bash user | ||
| RUN python setup.py install | ||
|
|
||
| RUN chown -R user /code/ | ||
| USER user | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,7 +4,7 @@ | |
| import logging | ||
| import pprint | ||
|
|
||
| from fig.packages import six | ||
| import six | ||
|
|
||
|
|
||
| def format_call(args, kwargs): | ||
|
|
||
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed this was wrong. It needs to install requirements.txt first because that has pinned versions, after it can install fig itself and all deps should already be installed.