Recommend boot2docker in installation instructions #508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfirsh
force-pushed
the
recommend-boot2docker-in-install-instructions
branch
3 times, most recently
from
4699764 to
7657e62
Compare
|
Agreed, bit messy. (Also, that Perhaps we could punt on the profile bit? That would make it a bit cleaner and less bash-specific.
Of course, there's then the danger that people won't understand that they need to set that environment variable somewhere more permanent than just in the current shell session. |
Fixes docker#26 Signed-off-by: Ben Firshman <ben@firshman.co.uk>
bfirsh
force-pushed
the
recommend-boot2docker-in-install-instructions
branch
from
7657e62 to
c16f4d4
Compare
|
LGTM |
aanand
added a commit
that referenced
this pull request
Oct 6, 2014
…instructions Recommend boot2docker in installation instructions
yuval-k
pushed a commit
to yuval-k/compose
that referenced
this pull request
Apr 10, 2015
…stall-instructions Recommend boot2docker in installation instructions Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The instructions to set up DOCKER_HOST seem a bit messy. Thoughts?
Fixes #26