-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Implement 'overwrite_mutlivals' config option #5354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Sherwood Callaway <shcallaway@gmail.com>
|
Do users want a generalized |
|
+1 |
|
@shcallaway I would vote for a generalized option... we have a use case where the So consider this a vote in favor of something more general than just ports. note, if I could "fish my wish" it would simply be that whatever key I put in an override would fully override that key, not append. That would mean if I have something like: services:
xyz:
ports:
- "443:9876"
depends_on:
- service-a
- service-b
- service-cand I wanted it to also depend on services:
xyz:
depends_on:
- service-a
- service-b
- service-c
- service-dCurrently, to just add an extra service, I can just add that one (because it appends) but I would much prefer the flexibility of a per-section overwrite. For example, in the case I mentioned at the start, if the base uses services:
xyz:
depends_on:
- service-a
- service-band be good to go. I know this may be a corner case, but the idea of only appending when it's a list just seems overly constrictive to me. |
|
Currently the only (besides the
The only difference between the dev and prod configs is some
Anyone? |
|
Please take this |
|
+1 |
|
Closing because this particular design won't be approved. I may revisit this feature in the future. |
In your
docker-compose.override.yml, theoverwrite_multivalsconfig option allows you to specify which multivalue fields should be overwritten instead of concatenated with the base.For example:
I am totally ripping off this guy's idea: #3939
This PR is a work in progress. Todo: