Add label config validation, fixes #4904 #5421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Drew Romanyk <drewiswaycool@gmail.com>
|
I think that test is wrong, actually. OTOH, now that we merged #5291 , there might be an opportunity to convert label values to string automatically instead. If you want to dig deeper that'd be a cool thing to do, but otherwise your PR is a good first step. |
Author
|
@shin- How should I handle cases where the labels could have '.' characters in them? EDIT: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Drew Romanyk drewiswaycool@gmail.com
Add validation for labels, fixes #4904
ASSUMPTIONS
This applies to all labels & all versions of docker compose
EDIT:
Since this failed, my assumption is wrong, is there any documentation on where to find which labels want strings only? As the docker compose docs didnt seem to tell (https://docs.docker.com/compose/compose-file/#labels). Or is it just the build labels that can allow numbers?