Allow dependent image pull from insecure registry #562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
1 similar comment
|
+1 |
|
I'm waiting for this as well |
|
@tjrivera Thanks for the contribution! Would really like to get this in Fig 1.0.1. Any chance we could get a test with a mocked client? |
|
As I understand it, this adds |
|
@aanand it already is |
|
👍 |
|
@aanand is that an LGTM? |
|
Yes, LGTM, though I wouldn't mind a test either. |
Author
Author
PR #490 Provides the ability to pull from an insecure registry by passing --allow-insecure-ssl. This commit extends the work done in #490 and adds the ability to pass --allow-insecure-ssl to the up and run commands which will attempt to pull dependent images if they do not exist. Signed-off-by: Tyler Rivera <riverat2@email.chop.edu>
|
LGTM |
1 similar comment
|
LGTM |
bfirsh
added a commit
that referenced
this pull request
Oct 22, 2014
Allow dependent image pull from insecure registry
|
Great stuff. Thanks @tjrivera! |
yuval-k
pushed a commit
to yuval-k/compose
that referenced
this pull request
Apr 10, 2015
Allow dependent image pull from insecure registry Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #490 Provides the ability to pull from an insecure registry by passing --allow-insecure-ssl. This commit extends the work done in #490 and adds the ability to pass --allow-insecure-ssl to the
upandruncommands which will attempt to pull dependent images if they do not exist.Signed-off-by: Tyler Rivera riverat2@email.chop.edu