Remove "bundle" subcommand and support for DAB files #7085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
thaJeztah
force-pushed
the
remove_dab_bundle
branch
2 times, most recently
from
a7bf5db to
3ba0d58
Compare
Deploying stacks using the "Docker Application Bundle" (`.dab`) file format was introduced as an experimental feature in Docker 1.13 / 17.03, but superseded by support for Docker Compose files in the CLI. With no development being done on this feature, and no active use of the file format, support for the DAB file format and the top-level `docker deploy` command (hidden by default in 19.03), will be removed from the CLI, in favour of `docker stack deploy` using compose files. This patch removes the `docker-compose bundle` subcommand from Docker Compose, which was used to convert compose files into DAB files (and given the above, will no longer be needed). Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
remove_dab_bundle
branch
from
3ba0d58 to
a3b1c4e
Compare
thaJeztah
requested review from
ndeloof,
rumpl and
ulyssessouza
as code owners
Member
Author
|
Fixed the linting issues, all green now 👍 |
ndeloof
approved these changes
Dec 7, 2019
Member
Author
|
@ulyssessouza ptal |
matt9ucci
added a commit
to matt9ucci/DockerComposeCompletion
that referenced
this pull request
Jun 4, 2020
Add completers: * -c, --context * build --progress * up --attach-dependencies Remove "bundle" subcommand <docker/compose#7085>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deploying stacks using the "Docker Application Bundle" (
.dab) file format was introduced as an experimental feature in Docker 1.13 / 17.03, but superseded by support for Docker Compose files in the CLI.With no development being done on this feature, and no active use of the file format, support for the DAB file format and the top-level
docker deploycommand (hidden by default in 19.03), will be removed from the CLI, in favour ofdocker stack deployusing compose files.This patch removes the
docker-compose bundlesubcommand from Docker Compose, which was used to convert compose files into DAB files (and given the above, will no longer be needed).