Rebrand bash completion script #871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harald Albers <github@albersweb.de>
|
Fantastic, thanks so much. LGTM |
|
LGTM |
dnephin
added a commit
that referenced
this pull request
Jan 22, 2015
Rebrand bash completion script
Author
|
Thanks for reviewing and merging so quickly! |
yuval-k
pushed a commit
to yuval-k/compose
that referenced
this pull request
Apr 10, 2015
Rebrand bash completion script Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker-createfigandfig.ymldocker-compose buildanddocker-compose pullwould not respect custom Compose-files (--file) when completing servicesApart from the last item, no functional changes were applied.
In order to not delay the rebranding process, I will add the new options in a subsequent PR.
@aanand @dnephin please review and schedule for the next release.