composeService to use dockerCli's In/Out/Err streams #9198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
force-pushed
the
dockerCli_stdout
branch
3 times, most recently
from
44a4c2c to
5bbe0ff
Compare
ndeloof
force-pushed
the
dockerCli_stdout
branch
from
5bbe0ff to
0409af1
Compare
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
ndeloof
force-pushed
the
dockerCli_stdout
branch
4 times, most recently
from
11b308c to
469f00a
Compare
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
ndeloof
force-pushed
the
dockerCli_stdout
branch
from
469f00a to
22b8c73
Compare
ndeloof
requested review from
glours and
ulyssessouza
and removed request for
glours
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
composeService is created from dockerCli and uses the assigned In/Out/Err streams
this also will let us
Related issue
(not mandatory) A picture of a cute animal, if possible in relation with what you did