Skip to content

Conversation

@immortal-tofu
Copy link

Adding extra_hosts parameter with doc and tests

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep this list sorted alphabetically (same with the list below)

@dnephin
Copy link

dnephin commented Feb 12, 2015

rebase with master to pickup the fix for those test failures, otherwise looks good

@immortal-tofu
Copy link
Author

Rebase done

@immortal-tofu
Copy link
Author

Fixed alphabetical order too

@aanand
Copy link

aanand commented Feb 13, 2015

Test appears to be failing:

FAIL: test_create_container_with_extra_hosts (tests.integration.service_test.ServiceTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/code/tests/integration/service_test.py", line 144, in test_create_container_with_extra_hosts
    ['myserver:192.168.2.90', 'myserver2:10.55.32.12'])
AssertionError: None != [u'myserver:192.168.2.90', u'myserver2:10.55.32.12']

@dnephin
Copy link

dnephin commented Feb 14, 2015

I think this feature requires docker 1.3 (http://docs.docker.com/v1.3/release-notes/), and if I remember correctly wercker is running docker 1.2, so I think this is blocking on #886 as well

Signed-off-by: Clément Danjou <clement.danjou@honeyvinegar.fr>
@immortal-tofu
Copy link
Author

Closed since this feature exists now in docker-compose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants