Skip to content

[DO NOT MERGE] make sure containerd runs with all libseccomp versions #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thaJeztah wants to merge 1 commit into from
Closed

[DO NOT MERGE] make sure containerd runs with all libseccomp versions #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion debian/control
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,22 @@ Source: containerd.io
Section: devel
Priority: optional
Maintainer: Containerd team <help@containerd.io>

# libseccomp-golang commit 9814e55a2e59df39b8ad4fbff1226585ebb84674 started using
# a new seccomp_version API, which was introduced in libseccomp 2.3 (addded in
# https://github.com/seccomp/libseccomp/commit/58a7c20). As a result, if the binary
# is compiled with libseccomp 2.3 or up, the minimum requirement for libseccomp
# to run the binary will also be libseccomp 2.3.0 (running on a system with an
# older version of libseccomp, will produce "undefined symbol: seccomp_version")
#
# Here, we restrict the version of libseccomp-dev at compile time to 2.2.x, so
# that the new API isn't used, and that the binary is compatible with libseccomp
# 2.2.0 and up. Running on a system with
Build-Depends: libbtrfs-dev | btrfs-tools ,
debhelper,
dh-systemd,
pkg-config,
libseccomp-dev
libseccomp-dev (<< 2.3.0)
Standards-Version: 4.1.4
Homepage: https://containerd.io
Vcs-Browser: https://github.com/containerd/containerd
Expand Down
13 changes: 12 additions & 1 deletion rpm/containerd.spec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,18 @@ Requires: container-selinux >= 2:2.74
BuildRequires: make
BuildRequires: gcc
BuildRequires: systemd
BuildRequires: libseccomp-devel

# libseccomp-golang commit 9814e55a2e59df39b8ad4fbff1226585ebb84674 started using
# a new seccomp_version API, which was introduced in libseccomp 2.3 (addded in
# https://github.com/seccomp/libseccomp/commit/58a7c20). As a result, if the binary
# is compiled with libseccomp 2.3 or up, the minimum requirement for libseccomp
# to run the binary will also be libseccomp 2.3.0 (running on a system with an
# older version of libseccomp, will produce "undefined symbol: seccomp_version")
#
# Here, we restrict the version of libseccomp-dev at compile time to 2.2.x, so
# that the new API isn't used, and that the binary is compatible with libseccomp
# 2.2.0 and up.
BuildRequires: libseccomp-devel << 2.3.0

# Should only return true if `el8` (rhel8) is NOT defined
%if 0%{!?el8:1}
Expand Down