Skip to content

rpm: add support for building on CentOS 8#148

Merged
silvin-lubecki merged 2 commits intodocker:masterfrom
thaJeztah:build_centos8
Mar 24, 2020
Merged

rpm: add support for building on CentOS 8#148
silvin-lubecki merged 2 commits intodocker:masterfrom
thaJeztah:build_centos8

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

replaces #118

@thaJeztah
Copy link
Copy Markdown
Member Author

seemethere
seemethere previously approved these changes Mar 23, 2020
@crosbymichael
Copy link
Copy Markdown
Contributor

LGTM

@thaJeztah
Copy link
Copy Markdown
Member Author

Failure on arm64;

+ dnf -y install make gcc systemd libseccomp-devel
Last metadata expiration check: 0:00:37 ago on Mon Mar 23 20:30:48 2020.
Package systemd-239-18.el8_1.1.aarch64 is already installed.
No match for argument: libseccomp-devel
Error: Unable to find a match: libseccomp-devel
Makefile:64: recipe for target 'build' failed
make: *** [build] Error 1

Looks like for arm64 it's in the PowerTools repo; https://centos.pkgs.org/8/centos-appstream-x86_64/libseccomp-devel-2.4.1-1.el8.x86_64.rpm.html

Arm32 images don't seem to be available, so I'll disable that

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
armhf (arm32) is currently not supported, because no images exist
on Docker Hub for CentOS 8

For arm64, the seccomp-devel package is in the PowerTools repository,
so enabling that repository on CentOS 8

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

centos: enable PowerTools repo

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Copy Markdown
Member Author

ok, updated;

  • disabled builds for arm32, because no image exists for CentOS 8 (arm32)
  • enabled the PowerTools repository so that (hopefully) arm64 completes successfully
  • removed obsolete sed for arm64

Copy link
Copy Markdown
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silvin-lubecki silvin-lubecki merged commit 4b7bddf into docker:master Mar 24, 2020
@thaJeztah thaJeztah deleted the build_centos8 branch March 24, 2020 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants