Skip to content

[main] rpm: minimal RHEL support (carry #342)#381

Merged
thaJeztah merged 2 commits into
docker:mainfrom
thaJeztah:carry_rhel_poc
Jul 23, 2024
Merged

[main] rpm: minimal RHEL support (carry #342)#381
thaJeztah merged 2 commits into
docker:mainfrom
thaJeztah:carry_rhel_poc

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

Implements passing the username and password through build-secrets instead of build-args


This is a PoC for building RHEL packages assuming that a RHEL username/password is available in the environment.

This is mostly intended for internal use by Docker, as it is assumed that the main utility is performing builds with a 'real RHEL' for enterprise customers. As such, there is currently no verification in this upstream repository.

However, when a unencumbered RHEL-equivalent distribution (e.g. Rocky) is supported, it will make sense to add verification for that distribution and generalize the 'rhel' infrastructure in this repo.

Signed-off-by: Bjorn Neergaard <bjorn.neergaard@docker.com>
@thaJeztah thaJeztah self-assigned this Jul 23, 2024
Signed-off-by: Bjorn Neergaard <bjorn.neergaard@docker.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Copy Markdown
Member Author

Looks like it all works; here's from our internal pipeline;

#14 [rhel-base 1/1] RUN --mount=type=secret,id=rh-user --mount=type=secret,id=rh-pass <<-EOT (rm -f /etc/rhsm-host...)
#14 3.873 Registering to: subscription.rhsm.redhat.com:443/subscription
#14 3.873 The system has been registered with ID: <REDACTED>
#14 3.873 The registered system name is: buildkitsandbox
#14 51.52 Repository 'codeready-builder-for-rhel-8-x86_64-rpms' is enabled for this system.
#14 DONE 54.3s

@thaJeztah thaJeztah marked this pull request as ready for review July 23, 2024 16:26
@thaJeztah
Copy link
Copy Markdown
Member Author

Failure of opensuse is unrelated; they have a major outage; #380 (comment)

@thaJeztah thaJeztah requested a review from vvoland July 23, 2024 16:32
Copy link
Copy Markdown
Contributor

@vvoland vvoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Copy Markdown
Member Author

Thx! Bringing this one in; failure is unrelated, and everything else is green 👍

@thaJeztah thaJeztah merged commit 9f27150 into docker:main Jul 23, 2024
@thaJeztah thaJeztah deleted the carry_rhel_poc branch July 23, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants