Fix --env-file support for the gateway#2085
Merged
dgageot merged 1 commit intodocker:mainfrom Mar 12, 2026
Merged
Conversation
Signed-off-by: David Gageot <david.gageot@docker.com>
krissetto
approved these changes
Mar 12, 2026
There was a problem hiding this comment.
Review Summary
Assessment: 🟢 APPROVE
Summary
This PR correctly implements --env-file support for gateway configuration by replacing os.Getenv() calls with env.Get(ctx, ...) from the environment provider chain. The change enables reading environment variables from files specified via --env-file while maintaining the existing precedence order.
Analysis:
- All four
env.Get()calls correctly ignore the bool return value (which indicates "found" vs "not found") - The code properly checks for non-empty values (
gateway != "",model != "") to determine whether to use the configuration - I/O errors from reading env files are already handled upstream in
computedEnvProvider()beforeGet()is called - This pattern matches standard Go conventions and is consistent with the codebase's environment package
Verdict: No issues found. The implementation is correct and follows established patterns in the codebase.
Automated review by docker-agent PR reviewer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.