Merged
Conversation
Signed-off-by: David Gageot <david.gageot@docker.com>
gtardif
approved these changes
Mar 12, 2026
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
Assessment: 🟢 APPROVE
Summary
This PR cleanly removes an experimental token refresh feature from pkg/desktop/login.go. The changes are purely deletive:
- Removes unused imports (log/slog, os, os/exec, time, jwt)
- Removes helper functions:
fetchToken(),isTokenExpired(), andrunDockerLogin() - Simplifies
GetToken()to only fetch the token without expiration checking or refresh logic
No bugs detected. The simplified GetToken() function correctly uses the existing ClientBackend.Get() API. All removed code was self-contained experimental functionality gated by the EXPERIMENTAL_DOCKER_TOKEN_REFRESH environment variable.
Findings
No issues found in the changed code.
This review focuses only on code added or modified in this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.