Skip to content

Remove syncMessagesColumn and legacy messages JSON column#2196

Merged
dgageot merged 1 commit intodocker:mainfrom
dgageot:board/remove-syncmessagescolumn-migration-clea-98aecb17
Mar 20, 2026
Merged

Remove syncMessagesColumn and legacy messages JSON column#2196
dgageot merged 1 commit intodocker:mainfrom
dgageot:board/remove-syncmessagescolumn-migration-clea-98aecb17

Conversation

@dgageot
Copy link
Copy Markdown
Member

@dgageot dgageot commented Mar 20, 2026

The messages JSON column on the sessions table was kept for backward compatibility with older docker-agent versions. This is no longer needed.

Changes

  • Remove syncMessagesColumn, syncMessagesColumnTx, syncMessagesColumnWith methods
  • Remove loadMessagesFromLegacyColumn fallback
  • Remove sync calls from AddMessage, UpdateMessage, AddSubSession, AddSummary
  • Add migration 020 to drop the messages column from the sessions table
  • Remove dead IsNoSuchColumnError helper from sqliteutil
  • Remove 4 backward/forward compatibility tests that validated the column
  • Clean up extra blank lines left by the removal

The messages JSON column on the sessions table was kept for backward
compatibility with older docker-agent versions. This is no longer needed.

- Remove syncMessagesColumn, syncMessagesColumnTx, syncMessagesColumnWith methods
- Remove loadMessagesFromLegacyColumn fallback
- Remove sync calls from AddMessage, UpdateMessage, AddSubSession, AddSummary
- Add migration 020 to DROP the messages column from the sessions table
- Remove 4 backward/forward compatibility tests that validated the column

Assisted-By: docker-agent
@dgageot dgageot requested a review from a team as a code owner March 20, 2026 14:32
docker-agent[bot]

This comment was marked as off-topic.

@dgageot dgageot merged commit 6dd5d72 into docker:main Mar 20, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants