Remove model alias resolution for inline agent model references#2206
Merged
dgageot merged 1 commit intodocker:mainfrom Mar 21, 2026
Merged
Remove model alias resolution for inline agent model references#2206dgageot merged 1 commit intodocker:mainfrom
dgageot merged 1 commit intodocker:mainfrom
Conversation
Assisted-By: docker-agent
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
No bugs detected in this change. The code removal is clean and complete:
- Removes inline model alias resolution logic for agent model references
- Updates all test expectations to match the new behavior
- No dangling references or incomplete removals
The change achieves its stated goal of avoiding resolved model names (e.g., claude-haiku-4-5-20251001) when using inline mode (anthropic/claude-haiku-4-5).
rumpl
approved these changes
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids seeing e.g.
claude-haiku-4-5-20251001when using inline modeanthropic/claude-haiku-4-5.Assisted-By: docker-agent