Skip to content

Reset tool loop detector after degenerate loop error #2237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgageot merged 1 commit into from
Mar 25, 2026
Merged

Reset tool loop detector after degenerate loop error #2237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/runtime/loop.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,6 +352,7 @@ func (r *LocalRuntime) RunStream(ctx context.Context, sess *session.Session) <-c
loopDetector.consecutive, toolName)
events <- Error(errMsg)
r.executeNotificationHooks(ctx, a, sess.ID, "error", errMsg)
loopDetector.reset()
return
}

Expand Down
6 changes: 6 additions & 0 deletions pkg/runtime/tool_loop_detector.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,12 @@ func newToolLoopDetector(threshold int) *toolLoopDetector {
return &toolLoopDetector{threshold: threshold}
}

// reset clears the detector state so it can be reused after recovery.
func (d *toolLoopDetector) reset() {
d.lastSignature = ""
d.consecutive = 0
}

// record updates the detector with the latest tool call batch and returns
// true if the consecutive-duplicate threshold has been reached.
func (d *toolLoopDetector) record(calls []tools.ToolCall) bool {
Expand Down
Loading