Open
Conversation
Signed-off-by: David Gageot <david.gageot@docker.com>
Signed-off-by: David Gageot <david.gageot@docker.com>
Signed-off-by: David Gageot <david.gageot@docker.com>
Add a retry counter (maxOverflowCompactions=1) to the auto-compaction path in the runtime loop. When every model call returns a ContextOverflowError, compaction is now attempted at most once before the error is surfaced to the user. The counter resets after each successful model call so future overflows can still trigger compaction. Add TestCompactionOverflowDoesNotLoop to verify the guard. Assisted-By: docker-agent
dgageot
force-pushed
the
refactor-compact
branch
from
ece8e04 to
be33f8b
Compare
rumpl
reviewed
Mar 25, 2026
| // (minus the expected max length of the summary). | ||
| contextLimit := max(0, int64(m.Limit.Context)-maxSummaryTokens) | ||
| var tokens int64 | ||
| for i := len(messages) - 1; i >= 0; i-- { |
Member
There was a problem hiding this comment.
This needs more work, the cutoff could be in the middle of a tool call and we could end up with a session that contains a tool call assistant message without a tool call result.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.