[master] rpm: fix missing GOTOOLCHAIN=local in centos, rhel Dockerfiles#1062
Merged
vvoland merged 1 commit intodocker:masterfrom Sep 4, 2024
Merged
[master] rpm: fix missing GOTOOLCHAIN=local in centos, rhel Dockerfiles#1062vvoland merged 1 commit intodocker:masterfrom
vvoland merged 1 commit intodocker:masterfrom
Conversation
Commit a4090a0 added GOTOOLCHAIN=local, but for some reason missed the centos Dockerfiles. The env-var is set to make sure we don't get unexpected updates of the go toolchain when building. We need to set this env-var, because we're not using the official golang image as base-image, but instead copy the binaries into a distro-image. This patch adds the missing GOTOOLCHAIN env-vars. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This was referenced Sep 4, 2024
vvoland
approved these changes
Sep 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit a4090a0 added GOTOOLCHAIN=local, but for some reason missed the centos Dockerfiles.
The env-var is set to make sure we don't get unexpected updates of the go toolchain when building. We need to set this env-var, because we're not using the official golang image as base-image, but instead copy the binaries into a distro-image.
This patch adds the missing GOTOOLCHAIN env-vars.