Skip to content

Conversation

@Romain-Geissler-1A
Copy link
Contributor

@Romain-Geissler-1A Romain-Geissler-1A commented Sep 12, 2025

Blindly copy the fedora 42 Dockerfile for fedora 43, just change the version number.

- Description for the changelog

Add Fedora 43 packages

Copy link
Contributor

@vvoland vvoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, but I think Fedora 43 isn't "out" yet so perhaps we should still give it some time before having official stable packages?

@Romain-Geissler-1A
Copy link
Contributor Author

In the past we have merged Fedora N support before its actual release (usually around the beta phase where things are stabilizing). If you mark this "not stable" then on the D day of the Fedora release packages won't be available (even after merging this, no new docker/containerd package will be made available until the next containerd/docker actual release, which on occasion can take some time).

I try to proactively send pull requests like these since couple of years since I regularly hit the issue that docker (I am especially interested in the docker client) was not installable from the quay.io/fedora/fedora OCI image more or less every 6 months and that created issues in my own CIs.

@vvoland
Copy link
Contributor

vvoland commented Sep 15, 2025

Thanks! I was missing the bit about Fedora 43 being released as beta this week. In this case I think it's good to have it already.

vvoland
vvoland previously approved these changes Sep 15, 2025
Signed-off-by: Romain Geissler <romain.geissler@amadeus.com>
@vvoland
Copy link
Contributor

vvoland commented Sep 16, 2025

@Romain-Geissler-1A do you have a moment to rebase this one? Jenkinsfile is gone now.

Otherwise I can rebase this one and get it in.

@vvoland
Copy link
Contributor

vvoland commented Sep 17, 2025

I went ahead and rebased this one, hope you don't mind! 🙈

@vvoland vvoland merged commit 80e47b2 into docker:master Sep 17, 2025
38 checks passed
@Romain-Geissler-1A
Copy link
Contributor Author

Thanks for the rebase, I was off yesterday.

So, don't we need docker/containerd-packaging#427 as well ? Because the resulting docker rpm packages won't be installable without the required containerd dependency.

@vvoland
Copy link
Contributor

vvoland commented Sep 17, 2025

No. Sorry for the confusion. We're in the middle of reworking the release pipeline.

Currently only docker/docker-ce-packaging and docker/packaging (containerd only) are used.

In the nearest future (after we get v29 out) the docker/packaging will be the source for building all packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants