Skip to content

[master] Add post-stop#168

Merged
docker-unir[bot] merged 1 commit into
docker:masterfrom
crosbymichael:prestart
Aug 28, 2018
Merged

[master] Add post-stop#168
docker-unir[bot] merged 1 commit into
docker:masterfrom
crosbymichael:prestart

Conversation

@crosbymichael
Copy link
Copy Markdown
Contributor

Signed-off-by: Michael Crosby crosbymichael@gmail.com

Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
Copy link
Copy Markdown
Contributor

@seemethere seemethere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seemethere
Copy link
Copy Markdown
Contributor

Does this also need a bump in the containerd proxy commit?

@crosbymichael
Copy link
Copy Markdown
Contributor Author

it should have already been done but things are getting lost

Copy link
Copy Markdown
Contributor

@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@docker-unir docker-unir Bot merged commit 8274734 into docker:master Aug 28, 2018
@andrewhsu andrewhsu changed the title Add post-stop [master] Add post-stop Aug 28, 2018
@andrewhsu
Copy link
Copy Markdown
Contributor

containerd proxy git commit bump was taken care of here: #163

@dhiltgen
Copy link
Copy Markdown
Contributor

@andrewhsu @crosbymichael this needs a cherry-pick to the 18.09 branch, correct?

@andrewhsu andrewhsu mentioned this pull request Aug 28, 2018
@crosbymichael crosbymichael deleted the prestart branch August 29, 2018 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants