Skip to content

[TAR-274] bump to golang 1.10.6#281

Merged
docker-unir[bot] merged 1 commit intodocker:masterfrom
seemethere:1_10_6
Dec 14, 2018
Merged

[TAR-274] bump to golang 1.10.6#281
docker-unir[bot] merged 1 commit intodocker:masterfrom
seemethere:1_10_6

Conversation

@seemethere
Copy link
Contributor

Signed-off-by: Eli Uriegas eli.uriegas@docker.com

Signed-off-by: Eli Uriegas <eli.uriegas@docker.com>
@seemethere seemethere requested review from a team, andrewhsu and thaJeztah December 13, 2018 23:47
@seemethere seemethere changed the title bump to golang 1.10.6 TAR-274 bump to golang 1.10.6 Dec 13, 2018
@seemethere seemethere changed the title TAR-274 bump to golang 1.10.6 [TAR-274] bump to golang 1.10.6 Dec 13, 2018
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member

@seemethere if we're gonna use "master" to build "nightly", we'll have to do a follow-up to bump to Go 1.11. I'll prepare a PR

@thaJeztah
Copy link
Member

Follow up PR: #283

Copy link
Contributor

@corbin-coleman corbin-coleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green

@docker-unir docker-unir bot merged commit 4612932 into docker:master Dec 14, 2018
@seemethere seemethere deleted the 1_10_6 branch December 17, 2018 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants