Skip to content

[TAR-1174][master] Turn Go11Module=off #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
docker-unir merged 2 commits into from
Oct 15, 2019
Merged

[TAR-1174][master] Turn Go11Module=off #396

docker-unir merged 2 commits into from
Oct 15, 2019

Conversation

@zelahi
Copy link
Contributor

@zelahi zelahi commented Oct 15, 2019

Turn Go11Module=off for building on go version 1.13

zelahi added 2 commits October 15, 2019 14:46
@zelahi
ADDED gomodules=off to docker-ce-packaging files
1b52d15 
Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>
@zelahi
Re-order common env variables
c1a42f9 
Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>
thaJeztah
thaJeztah approved these changes Oct 15, 2019
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@docker-unir docker-unir bot merged commit 069ea9c into docker:master Oct 15, 2019
@glours glours mentioned this pull request Apr 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes

+1 more reviewer

@seemethere seemethere seemethere approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zelahi @seemethere @thaJeztah