[master] Dockerfiles: re-use DISTRO, SUITE build-args where poss… #403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-use these build-args, so that there's only one place to set them per Dockerfile.
To verify this change:
Check if the env-vars are set on the image:
```bash
make UBUNTU_VERSIONS=ubuntu-bionic DEBIAN_VERSIONS="" RASPBIAN_VERSIONS="" CLI_DIR=$GOPATH/src/github.com/docker/cli ENGINE_DIR=$GOPATH/src/github.com/docker/docker deb
docker image inspect debbuild-ubuntu-bionic/x86_64 --format '{{json .Config.Env }}' | jq .
```
Which should output something like;
```json
[
"PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/local/go/bin:/go/bin",
"GOPROXY=direct",
"GO111MODULE=off",
"GOPATH=/go",
"DOCKER_BUILDTAGS=apparmor seccomp selinux",
"RUNC_BUILDTAGS=apparmor seccomp selinux",
"DISTRO=ubuntu",
"SUITE=bionic"
]
```
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
distro_suite_args
branch
from
f6ece49 to
a996681
Compare
thaJeztah
changed the title
Member
Author
|
ping @seemethere @zelahi ptal 🤗 |
zelahi
approved these changes
Oct 23, 2019
Member
Author
|
ping @StefanScherer @andrewhsu @seemethere ptal |
seemethere
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on top of #399 - I'll rebase once that's merged.doneRe-use these build-args, so that there's only one place to set them per Dockerfile.
To verify this change:
Check if the env-vars are set on the image:
Which should output something like;