Skip to content

[master] Remove some remnants related to image-based builds #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thaJeztah merged 1 commit into from
Jan 21, 2020
Merged

[master] Remove some remnants related to image-based builds #420

thaJeztah merged 1 commit into from
Jan 21, 2020

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Jan 21, 2020 •
edited
Loading

Looks like these were left behind in #411

relates to docker/cli#2213

@thaJeztah
Remove some remnants related to image-based builds
ca70795 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah mentioned this pull request Jan 21, 2020
Closed
8 tasks
@thaJeztah
Copy link
Member Author

thaJeztah commented Jan 21, 2020

@silvin-lubecki @StefanScherer @seemethere PTAL

StefanScherer
StefanScherer approved these changes Jan 21, 2020
View reviewed changes
Copy link
Member

@StefanScherer StefanScherer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member Author

thaJeztah commented Jan 21, 2020

I'll go ahead and merge this one

@thaJeztah thaJeztah merged commit 7730ce0 into docker:master Jan 21, 2020
@thaJeztah thaJeztah deleted the remove_activate_remnants branch January 21, 2020 20:52
silvin-lubecki
silvin-lubecki reviewed Jan 22, 2020
View reviewed changes
Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@thaJeztah thaJeztah mentioned this pull request Jan 22, 2020
Merged
@glours glours mentioned this pull request Apr 14, 2020
Merged
@thaJeztah thaJeztah changed the title Remove some remnants related to image-based builds [master] Remove some remnants related to image-based builds May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@silvin-lubecki silvin-lubecki silvin-lubecki left review comments

@StefanScherer StefanScherer StefanScherer approved these changes

@seemethere seemethere seemethere approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thaJeztah @StefanScherer @seemethere @silvin-lubecki