-
Notifications
You must be signed in to change notification settings - Fork 161
[master] fetch source from upstream docker/docker repository #457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+112
−67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2acd047 to
d1f5c41
Compare
This comment has been minimized.
This comment has been minimized.
f61c9fa to
648a2cc
Compare
648a2cc to
2e55093
Compare
2e55093 to
7263b38
Compare
7263b38 to
1aa74b7
Compare
Contributor
|
Needs rebase |
A default version is already set in the Makefile itself Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
0b06bc6 to
ebe9dc7
Compare
Member
Author
|
moved the "shallow clone" commit to a separate PR as it may need some more work; #473 |
Contributor
|
@silvin-lubecki @tiborvass PTAL? |
Member
Author
silvin-lubecki
approved these changes
Jun 4, 2020
Contributor
silvin-lubecki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Contributor
|
@tiborvass @glours LGTY? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various changes in this PR:
DOCKER_CLI_REPO,DOCKER_ENGINE_REPO,REF,DOCKER_CLI_REFandDOCKER_ENGINE_REFmake variables to allow overriding the repository and reference to build from.ENGINE_DIRorCLI_DIRis specified, copy the source instead of cloning (to keep the source in a fixed location)