Add PIDFile to docker.service unit file to make systemd clean up pid file more reliably#499
Closed
qiutongs wants to merge 1 commit into
Closed
Add PIDFile to docker.service unit file to make systemd clean up pid file more reliably#499qiutongs wants to merge 1 commit into
qiutongs wants to merge 1 commit into
Conversation
…file more reliably - What I did In docker.service unit file, add a PIDFile option with the default pid file path of docker. - Why I did In the case of a high churn process system there is an edge case where the process is killed and the process id is assigned to a new running process before systemd can restart the process and see that no process is running under the old pid. When the in-use PIDs is close to the system capacity, it's likely that the PID has been reused by some other process. The dockerd does a check to see if the pid file exist and the process id in the file is running[3]. In this case, docker will fail to restart since the pid file contains a valid, running process. So configuring the PIDFile in docker.service, systemd will help cleanup the pid file more reliably. - How I did it Updated the docker.service - How to verify it Try to simulate the high churn behavior. Signed-off-by: Qiutong Song <qiutongs@google.com>
Member
|
We upstreamed the systemd unit files from this repository back to moby/moby (moby/moby#42373) and removed them in this repository (#547), so let's close this one in favour of moby/moby#41465 (looks like there's still some discussion ongoing on that PR), thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For details, refer to moby/moby#41465