[master] deb/rpm define dependencies between docker-ce-cli and docker-compose-plugin#555
Merged
thaJeztah merged 2 commits intodocker:masterfrom Mar 27, 2022
Merged
Conversation
dd70a0e to
9239ac2
Compare
This adds a "weak" dependency on the docker-compose-plugin, per the recommendations in https://debian-handbook.info/browse/stable/sect.package-meta-information.html#id-1.8.6.7.10.10 The "recommends" dependency will be installed by default, but does allow users to opt-out using `--no-install-recommends` to perform a lightweight installation for setups that only need basic functionality of docker; > (...) the “recommended” dependencies, the most important, considerably improve > the functionality offered by the package but are not indispensable to its operation. > (...) You should always install the “recommended” packages, unless you know exactly > why you do not need them. This is now also the default for APT unless configured > otherwise. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This defines the dependency between the docker cli and compose (as a plugin). RHEL8 and CentOS 8 (and up) support weak dependencies; - https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8/html/packaging_and_distributing_software/new-features-in-rhel-8_packaging-and-distributing-software#support-for-weak-dependencies_new-features-in-rhel-8 - https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8/html/packaging_and_distributing_software/new-features-in-rhel-8_packaging-and-distributing-software#boolean-dependencies-syntax But CentOS 7 and RHEL 7 do not yet support this, so for those, we use "Requires", using the `%rhel` macro for detection, which also works on CentOS: rpm --eval '%{rhel}' 7 Making the dependency _recommended_ will install it by default, but users _are_ able to opt-out explicitly, using `--setopt=install_weak_deps=False`, for example, to perform a light-weight installation that does not require all features of Docker. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
9239ac2 to
bb4bd31
Compare
crazy-max
approved these changes
Mar 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #553
With this change, the compose-cli-plugin will automatically be installed as dependency of the cli.
deb: add docker-compose-plugin as "recommends"
This adds a "weak" dependency on the docker-compose-plugin, per the
recommendations in https://debian-handbook.info/browse/stable/sect.package-meta-information.html#id-1.8.6.7.10.10
The "recommends" dependency will be installed by default, but does allow users to opt-out
using
--no-install-recommendsto perform a lightweight installation for setups that onlyneed basic functionality of docker;
rpm: add docker-compose-plugin as "recommends" / "requires"
This defines the dependency between the docker cli and compose (as a plugin). RHEL8
and CentOS 8 (and up) support weak dependencies;
But CentOS 7 and RHEL 7 do not yet support this, so for those, we use "Requires",
using the
%rhelmacro for detection, which also works on CentOS:Making the dependency recommended will install it by default, but users are able
to opt-out explicitly, using
--setopt=install_weak_deps=False, for example, toperform a light-weight installation that does not require all features of Docker.