Skip to content

Conversation

@thaJeztah
Copy link
Member

This reverts commit f9ac2f6 (#686), as it unfortunately won't work with ubuntu 18.04

We can work on this later, to see if we can find a suitable workaround

This reverts commit f9ac2f6.
as it unfortunately won't work with ubuntu 18.04, which doesn't
have debhelper-compat 12 (11 is the default, but that version
is discouraged).

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah force-pushed the revert_debhelper_update branch from cafa42d to cafc21c Compare May 19, 2022 17:06
@thaJeztah
Copy link
Member Author

Well... of course, why not?

+ git -C src/github.com/docker/cli fetch --update-head-ok --depth 1 origin refs/heads/master:refs/heads/master
fatal: unable to access 'https://github.com/docker/cli.git/': Failed to connect to github.com port 443: Connection timed out
make: *** [Makefile:55: checkout-cli] Error 128
script returned exit code 2

@thaJeztah
Copy link
Member Author

whoop; green now

@thaJeztah thaJeztah merged commit 6e7db7f into docker:master May 19, 2022
@thaJeztah thaJeztah deleted the revert_debhelper_update branch May 19, 2022 17:45
@tianon
Copy link
Contributor

tianon commented May 19, 2022

To unpack this a little bit more, I think to be able to reconsider what I was trying to do in #686 we'd really need to either drop support for bionic (not great as it's still very popular with users) or make it work somehow with compat level 10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants