Skip to content

Broken yum config-manager command on CentOS 7#448

Merged
thaJeztah merged 1 commit into
docker:masterfrom
singhsegv:fix/yum
Sep 24, 2024
Merged

Broken yum config-manager command on CentOS 7#448
thaJeztah merged 1 commit into
docker:masterfrom
singhsegv:fix/yum

Conversation

@singhsegv
Copy link
Copy Markdown
Contributor

@singhsegv singhsegv commented Sep 24, 2024

- What I did
"yum config-manager" to "yum-config-manager"

- How I did it

- How to verify it

- Description for the changelog

The install script seems to be broken on CentOS 7. It results in "--add-repo not found" error. The actual issue seems from be about config-manager command not being there even after installation of yum-utils

No such command: config-manager. Please use /usr/bin/yum --help

Installing yum-utils should enable yum config-manager command in later versions of the OS (haven't tested) but it doesn't do it on the CentOS 7. This PR is to point this issue out and maybe someone can test on the newers OS versions if yum-config-manager is good to go or not. Thanks.

- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: rajdeep1008 <iamrajdeep1008@gmail.com>
@thaJeztah
Copy link
Copy Markdown
Member

Doh! Looks like I broke this in b982474, which was part of;

I should warn though that we no longer support CentOS 7 (which was the last distro using yum) as it reached EOL, so no updated packages will be published, and the portions of the script that use yum may eventually be removed.

So if you're still running CentOS 7 (or 8), make sure you update to a supported distro.

Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thaJeztah thaJeztah merged commit 6d51e2c into docker:master Sep 24, 2024
@GantzGit
Copy link
Copy Markdown

GantzGit commented Oct 8, 2024

Was this pushed through to the get.docker.com site? I am seeing that the site is still outputting 'yum config-manager' :

Screenshot 2024-10-08 at 3 12 51 PM

@thaJeztah
Copy link
Copy Markdown
Member

Hm... let me check; I think a deploy was triggered at the time, but wondering if something failed.

@thaJeztah
Copy link
Copy Markdown
Member

Triggered a new deploy; looks to be all good now, and at commit 6d51e2c

curl -fsSL get.docker.com | grep 'SCRIPT_COMMIT_SHA='
SCRIPT_COMMIT_SHA="6d51e2cd8c04b38e1c2237820245f4fc262aca6c"

curl -fsSL test.docker.com | grep 'SCRIPT_COMMIT_SHA='
SCRIPT_COMMIT_SHA="6d51e2cd8c04b38e1c2237820245f4fc262aca6c"

curl -fsSL get.docker.com/rootless | grep 'SCRIPT_COMMIT_SHA='
SCRIPT_COMMIT_SHA=6d51e2c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants