Support definition lookups on wsl$ hosts

CHANGELOG.md

@@ -15,6 +15,8 @@ All notable changes to the Docker Language Server will be documented in this fil
 - Bake
   - textDocument/codeLens
     - refactor the URI handling code so it will accept a WSL URI with a dollar sign ([#388](https://github.com/docker/docker-language-server/issues/388))
+  - textDocument/definition
+    - handle WSL URIs with a dollar sign properly to fix file looks up on those hosts ([#390](https://github.com/docker/docker-language-server/issues/390))
   - textDocument/documentLink
     - convert links properly if a WSL URI with a dollar sign is used ([#378](https://github.com/docker/docker-language-server/issues/378))
   - textDocument/inlineCompletion

internal/bake/hcl/definition.go

@@ -114,15 +114,15 @@ func ResolveExpression(ctx context.Context, definitionLinkSupport bool, manager
 
 	if literalValueExpr, ok := expression.(*hclsyntax.LiteralValueExpr); ok && sourceBlock != nil && sourceBlock.Type == "target" {
 		if attributeName == "no-cache-filter" || attributeName == "target" {
-			dockerfilePath, err := doc.DockerfileForTarget(sourceBlock)
+			dockerfileURI, dockerfilePath, err := doc.DockerfileDocumentPathForTarget(sourceBlock)
 			if dockerfilePath == "" || err != nil {
 				return nil
 			}
 
 			value, _ := literalValueExpr.Value(&hcl.EvalContext{})
 			target := value.AsString()
 
-			bytes, nodes := document.OpenDockerfile(ctx, manager, "", dockerfilePath)
+			bytes, nodes := document.OpenDockerfile(ctx, manager, dockerfileURI, dockerfilePath)
 			lines := strings.Split(string(bytes), "\n")
 			for _, child := range nodes {
 				if strings.EqualFold(child.Value, "FROM") {
@@ -154,7 +154,7 @@ func ResolveExpression(ctx context.Context, definitionLinkSupport bool, manager
 									Character: uint32(uint32(literalValueExpr.Range().End.Column) - 1),
 								},
 							},
-							protocol.URI(fmt.Sprintf("file:///%v", strings.TrimPrefix(filepath.ToSlash(dockerfilePath), "/"))),
+							protocol.URI(dockerfileURI),
 						)
 					}
 				}