Clean up created volume from test_run_with_named_volume#1909
Merged
Conversation
This fix adds the volume id to the list so that it could be cleaned up on test teardown. The issue was originally from moby/moby#36292 where an additional `somevolume` pre-exists in tests. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Contributor
|
Thanks! |
yongtang
added a commit
to yongtang/docker
that referenced
this pull request
Feb 15, 2018
This fix updates docker-py: ``` -ENV DOCKER_PY_COMMIT 1d6b5b203222ba5df7dedfcd1ee061a452f99c8a +ENV DOCKER_PY_COMMIT 5e28dcaace5f7b70cbe44c313b7a3b288fa38916 ``` The updated docker-py includes docker/docker-py#1909 which is required to have moby#36292 pass the tests. Full diff is in docker/docker-py@1d6b5b2...5e28dca. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
docker-jenkins
pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
Feb 15, 2018
This fix updates docker-py: ``` -ENV DOCKER_PY_COMMIT 1d6b5b203222ba5df7dedfcd1ee061a452f99c8a +ENV DOCKER_PY_COMMIT 5e28dcaace5f7b70cbe44c313b7a3b288fa38916 ``` The updated docker-py includes docker/docker-py#1909 which is required to have #36292 pass the tests. Full diff is in docker/docker-py@1d6b5b2...5e28dca. Signed-off-by: Yong Tang <yong.tang.github@outlook.com> Upstream-commit: 9d9af83 Component: engine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix adds the volume id to the list so that it could be
cleaned up on test teardown.
The issue was originally from moby/moby#36292
where an additional
somevolumepre-exists in tests.Signed-off-by: Yong Tang yong.tang.github@outlook.com