Cleanup containers during the tests#1922
Merged
Merged
Conversation
This fix tries to clean up the containers during the tests so that no pre-existing volumes left in docker integration tests. This fix adds `-v` when removing containers, and makes sure containers launched in non-daemon mode are removed. This fix is realted to moby PR 36292 Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
This was referenced Feb 23, 2018
Member
|
ping @shin- 🤗 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix tries to clean up the containers during the tests
so that no pre-existing volumes left in docker integration tests.
This fix adds
-vwhen removing containers, and makes surecontainers launched in non-daemon mode are removed.
This fix is related to moby/moby#36292
Signed-off-by: Yong Tang yong.tang.github@outlook.com