[Bug report] Add support for Python 3.12 #3176
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The second and final Python 3.12 release candidate is out! 🚀
See also https://dev.to/hugovk/help-test-python-312-beta-1508/
The full Python 3.12.0 release is in under a month: 2023-10-02.
Bug report
Consider this a PR a bug report, the Python 3.12 build fails:
This is because
ssl.match_hostnamewas removed in Python 3.12 after being deprecated in 3.7:Replacements
Here's how a couple of other projects dealt with it:
ssl.match_hostnamessl.match_hostnamemethod (fixes: #368) aiortc/aioquic#389 replacedssl.match_hostnamewith PyCA'sservice-identityFeel free to use this PR as a starting point for fixing it as you see best, or close this as needed.
Thanks!