Separate params stream and follow for logs. #942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 'stdout': stdout and 1 or 0, | ||
| 'timestamps': timestamps and 1 or 0, | ||
| 'follow': stream and 1 or 0, | ||
| 'follow': follow and 1 or 0, |
Contributor
There was a problem hiding this comment.
I wonder if we should set follow=None and do:
'follow': follow if follow is not None else int(stream)to keep it backwards compatible
Contributor
|
Looks good, just one consideration for backwards compatibility. |
Closes docker#934 Signed-off-by: Stéphane Seguin <stephseguin93@gmail.com>
seguins
force-pushed
the
934-separate-stream-follow-logs
branch
from
a08699e to
71fafd3
Compare
Contributor
Author
|
I have added the backward compatibility and I have created a new unit test for it. |
Contributor
|
LGTM |
Contributor
|
LGTM, thanks! |
shin-
added a commit
that referenced
this pull request
Feb 25, 2016
Separate params stream and follow for logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #934