tmpfs support #994
Merged
tmpfs support #994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for the Tmpfs option introduced in Docker 1.10. See: moby/moby#13587 Signed-off-by: Jan Losinski <losinski@wh2.tu-dresden.de>
Signed-off-by: Jan Losinski <losinski@wh2.tu-dresden.de>
Signed-off-by: Jan Losinski <losinski@wh2.tu-dresden.de>
Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
aanand
force-pushed
the
janLo-tmpfs-support
branch
from
0ef40d7 to
5c8e68b
Compare
Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
aanand
force-pushed
the
janLo-tmpfs-support
branch
from
5c8e68b to
496767e
Compare
|
|
||
| self.tmp_containers.append(container['Id']) | ||
| config = self.client.inspect_container(container) | ||
| assert config['HostConfig']['Tmpfs'] == tmpfs |
Contributor
There was a problem hiding this comment.
This is failing with a KeyError for some reason, I'm not sure why, it seems to be correct to me.
Contributor
|
Code looks good, but the test is failing for some reason |
Contributor
Author
|
Ah, it's because of the Engine version (1.9.0). I'll decorate the test. |
Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
aanand
force-pushed
the
janLo-tmpfs-support
branch
2 times, most recently
from
72face4 to
6cc6474
Compare
Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
aanand
force-pushed
the
janLo-tmpfs-support
branch
from
6cc6474 to
7417bc2
Compare
| @@ -0,0 +1,33 @@ | |||
| # Using tmpfs | |||
Contributor
There was a problem hiding this comment.
This file needs to be indexed in mkdocs.yml
Contributor
|
Minor docs comment, apart from that, LGTM. |
Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
Contributor
Author
|
Updated |
Contributor
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sits on / replaces #939.