-
Notifications
You must be signed in to change notification settings - Fork 8.2k
ubuntu: add instructions for updating package repositories #10285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
thaJeztah
wants to merge
1
commit into
docker:main
Choose a base branch
from
thaJeztah:install_distro_update_instructions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@seemethere @tianon wondering if there's a way to remove all
download.docker.com(using a wildcard?) references, and if we should add such a step to theget.docker.cominstallation script.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO we should just make sure
get.docker.comalways uses the same filename, which solves the issue in a simpler way for folks who use the script.We could do something clever here with
find+sedto remove all references, but I think just an examplegrepto help them find the offending entries would be cleaner (and puts the onus of accidentally screwing upsources.liston the user instead 😅😇).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean; instead of having separate directories/repositories for each version of the distro (
disco,xenial, ..), have all packages in the same location (not exactly sure how the indexes work internally for.debrepositories 😅)? Or do you mean; make sure we always write the repository to a file inside/etc/apt/sources.list.dinstead of append it to/etc/apt/sources.list/?Yes, so that was my main train of thought with using the
add-apt-repository --removeutility to just remove it (assuming that's relatively safe, and wouldn't do harm to other repositories), followed by adding the new / right repository.I could have a look at providing a
grepexample, or just keep it at "do whatever you usually do, but you likely want to be looking in this file" (as I have currently tried to write it); wdyt?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I just mean
/etc/apt/sources.list.d/docker.listconsistently like @seemethere mentioned. 👍Yeah, my thought was something as simple as
grep -rnF 'docker.com' /etc/apt/sources.list*, which should tell them where they've got an entry for it already:I'm definitely a fan of avoiding
add-apt-repositorybecause IMO it's extraneous (and isn't installed in minimal systems).