Skip to content

Update debian.md #11974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wschwab wants to merge 1 commit into from
Closed

Update debian.md #11974

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion engine/install/debian.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,16 @@ from the repository.
```bash
$ curl -fsSL {{ download-url-base }}/gpg | sudo apt-key add -
```

Newer versions of Debian have deprecated using `apt-key` like this. If you
are receiving the following error:
```
Warning: apt-key is deprecated. Manage keyring files in trusted.gpg.d instead (see apt-key(8)).
```
then you can avoid it by using the following instead:
```
curl -fsSL https://download.docker.com/linux/debian/gpg | sudo apt-key --keyring /etc/apt/trusted.gpg.d/docker-apt-key.gpg add -
Copy link
Member

@thaJeztah thaJeztah Jan 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this also work on older versions? If so, we should probably replace the existing instructions to use the new one

This should probably also use the variable;

Suggested change
curl -fsSL https://download.docker.com/linux/debian/gpg | sudo apt-key --keyring /etc/apt/trusted.gpg.d/docker-apt-key.gpg add -
curl -fsSL {{ download-url-base }}/gpg | sudo apt-key --keyring /etc/apt/trusted.gpg.d/docker-apt-key.gpg add -

Copy link
Contributor

@denis-roy denis-roy Jan 5, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good day @thaJeztah

As per my previous comment, this solution and the requested changes still rely on the deprecated apt-key tool.

#11990 offers a Debian-compliant way of dealing with apt-key deprecation that applies to Debian 9 (Stretch) / Ubuntu 16.04 (Xenial) onward which is in line with Docker's own installation requirements.

Thank you :)

Copy link

@ankostis ankostis Jan 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the verification command needs also --keyring /etc/apt/trusted.gpg.d/docker-apt-key.gpg, below.

```

Verify that you now have the key with the fingerprint
`9DC8 5822 9FC7 DD38 854A E2D8 8D81 803C 0EBF CD88`, by searching for the
last 8 characters of the fingerprint.
Expand Down