Skip to content

Conversation

@vpalmerini
Copy link

Proposed changes

Fix formatting in templates of pages: commandline/build, commandline/builder_build, commandline/buildx_build and commandline/image_build.
The templates were not recognizing the < and > in the description of --ssh option, so this PR adds a \ before each sign so the formatting can be preserved.

Before:
image

Now:
image

Related issues

Closes #11331

@netlify
Copy link

netlify bot commented Jan 7, 2021

✔️ Deploy preview for docsdocker ready!

🔨 Explore the source changes: dff66cf

🔍 Inspect the deploy logs: https://app.netlify.com/sites/docsdocker/deploys/5ff7581ed712f900071a9923

😎 Browse the preview: https://deploy-preview-12064--docsdocker.netlify.app

@vpalmerini vpalmerini force-pushed the fix-formatting-in-build-sections branch from e1b1dee to dff66cf Compare January 7, 2021 18:51
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for contributing! Unfortunately, I don't think this is the right fix, because these YAML files are generated from source, so manual updates to these files would be reverted when they are updated with a newly generated version.

Let me open a pull request with a fix to handle escaping these characters in our Jekyll template instead

@thaJeztah
Copy link
Member

opened #12083

@vpalmerini
Copy link
Author

Oh, makes sense. Thanks for the feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect HTML output

2 participants