Skip to content

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah added the area/engine Issue affects Docker engine/daemon label Oct 7, 2021
@netlify
Copy link

netlify bot commented Oct 7, 2021

✔️ Deploy Preview for docsdocker ready!

🔨 Explore the source changes: 373ec2c

🔍 Inspect the deploy log: https://app.netlify.com/sites/docsdocker/deploys/6165fa6dff41db0009d7b37b

😎 Browse the preview: https://deploy-preview-13660--docsdocker.netlify.app

You need at least version 2.0 of CRIU to run checkpoint/restore in Docker.
### Use cases for checkpoint & restore
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Use cases for checkpoint & restore
### Use cases for checkpoint and restore

- "Rewinding" processes to an earlier point in time
- "Forensic debugging" of running processes
Another primary use case of checkpoint & restore outside of Docker is the live
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Another primary use case of checkpoint & restore outside of Docker is the live
Another primary use case of checkpoint and restore outside of Docker is the live

abc0123
```
This process just logs an incrementing counter to stdout. If you `docker logs`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This process just logs an incrementing counter to stdout. If you `docker logs`
This process just logs an incrementing counter to stdout. If you run `docker logs`

### Installing CRIU
If you use a Debian system, you can add the CRIU PPA and install with apt-get
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you use a Debian system, you can add the CRIU PPA and install with apt-get
If you use a Debian system, you can add the CRIU PPA and install with `apt-get`

Alternatively, you can [build CRIU from source](https://criu.org/Installation).
You need at least version 2.0 of CRIU to run checkpoint/restore in Docker.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You need at least version 2.0 of CRIU to run checkpoint/restore in Docker.
You need at least version 2.0 of CRIU to run checkpoint and restore in Docker.

- `ls` (lists existing checkpoints)
- `rm` (deletes an existing checkpoint)
Additionally, a `--checkpoint` flag is added to the container start command.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Additionally, a `--checkpoint` flag is added to the container start command.
Additionally, a `--checkpoint` flag is added to the `container start` command.

--checkpoint-dir Use a custom checkpoint storage directory
```
And to restore a container:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
And to restore a container:
To restore a container:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, looks like I missed this one; will keep that for a follow-up

### Known limitations
seccomp is only supported by CRIU in very up to date kernels.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
seccomp is only supported by CRIU in very up to date kernels.
seccomp is only supported by CRIU in very up-to-date kernels.

@usha-mandya
Copy link
Member

Thanks @thaJeztah. LGTM with some minor style and format suggestions

@thaJeztah
Copy link
Member Author

I'll have a look at those changes (will have to be made in the cli and backported); this was just a move of an existing file that was already in the CLI, but previously not included in the reference docs

@thaJeztah
Copy link
Member Author

I opened docker/cli#3333 and docker/cli#3334 to address the review comments in the docker/cli repository

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah force-pushed the update_engine_reference2 branch from 48a466a to 373ec2c Compare October 12, 2021 21:13
@thaJeztah
Copy link
Member Author

@usha-mandya updated with the changes from docker/cli#3334; PTAL

Copy link
Member

@usha-mandya usha-mandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@usha-mandya usha-mandya merged commit cf83d6d into docker:master Oct 13, 2021
@thaJeztah thaJeztah deleted the update_engine_reference2 branch October 13, 2021 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/engine Issue affects Docker engine/daemon

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants