-
Notifications
You must be signed in to change notification settings - Fork 8.1k
update engine reference docs with latest changes #13660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
✔️ Deploy Preview for docsdocker ready! 🔨 Explore the source changes: 373ec2c 🔍 Inspect the deploy log: https://app.netlify.com/sites/docsdocker/deploys/6165fa6dff41db0009d7b37b 😎 Browse the preview: https://deploy-preview-13660--docsdocker.netlify.app |
| You need at least version 2.0 of CRIU to run checkpoint/restore in Docker. | ||
| ### Use cases for checkpoint & restore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ### Use cases for checkpoint & restore | |
| ### Use cases for checkpoint and restore |
| - "Rewinding" processes to an earlier point in time | ||
| - "Forensic debugging" of running processes | ||
| Another primary use case of checkpoint & restore outside of Docker is the live |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Another primary use case of checkpoint & restore outside of Docker is the live | |
| Another primary use case of checkpoint and restore outside of Docker is the live |
| abc0123 | ||
| ``` | ||
| This process just logs an incrementing counter to stdout. If you `docker logs` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| This process just logs an incrementing counter to stdout. If you `docker logs` | |
| This process just logs an incrementing counter to stdout. If you run `docker logs` |
| ### Installing CRIU | ||
| If you use a Debian system, you can add the CRIU PPA and install with apt-get |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| If you use a Debian system, you can add the CRIU PPA and install with apt-get | |
| If you use a Debian system, you can add the CRIU PPA and install with `apt-get` |
| Alternatively, you can [build CRIU from source](https://criu.org/Installation). | ||
| You need at least version 2.0 of CRIU to run checkpoint/restore in Docker. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| You need at least version 2.0 of CRIU to run checkpoint/restore in Docker. | |
| You need at least version 2.0 of CRIU to run checkpoint and restore in Docker. |
| - `ls` (lists existing checkpoints) | ||
| - `rm` (deletes an existing checkpoint) | ||
| Additionally, a `--checkpoint` flag is added to the container start command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Additionally, a `--checkpoint` flag is added to the container start command. | |
| Additionally, a `--checkpoint` flag is added to the `container start` command. |
| --checkpoint-dir Use a custom checkpoint storage directory | ||
| ``` | ||
| And to restore a container: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| And to restore a container: | |
| To restore a container: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, looks like I missed this one; will keep that for a follow-up
| ### Known limitations | ||
| seccomp is only supported by CRIU in very up to date kernels. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| seccomp is only supported by CRIU in very up to date kernels. | |
| seccomp is only supported by CRIU in very up-to-date kernels. |
|
Thanks @thaJeztah. LGTM with some minor style and format suggestions |
|
I'll have a look at those changes (will have to be made in the cli and backported); this was just a move of an existing file that was already in the CLI, but previously not included in the reference docs |
|
I opened docker/cli#3333 and docker/cli#3334 to address the review comments in the docker/cli repository |
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
48a466a to
373ec2c
Compare
|
@usha-mandya updated with the changes from docker/cli#3334; PTAL |
usha-mandya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@usha-mandya ptal