Skip to content

Conversation

@usha-mandya
Copy link
Member

Signed-off-by: Usha Mandya usha.mandya@docker.com

Remove Docker app docs from the CLI reference

@usha-mandya usha-mandya added the area/cli Relates to the CLI client label Apr 1, 2022
@usha-mandya usha-mandya requested a review from thaJeztah April 1, 2022 13:54
@usha-mandya
Copy link
Member Author

usha-mandya commented Apr 1, 2022

@thaJeztah PTAL. Is there anything I should do in addition to removing the stubs and adding redirects? I don't see the generated yaml files in the repo. Guess these have already been removed.

@netlify
Copy link

netlify bot commented Apr 1, 2022

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit d0a4e35
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/624705cf69ca0d00084e04cc
😎 Deploy Preview https://deploy-preview-14492--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Signed-off-by: Usha Mandya <usha.mandya@docker.com>
@thaJeztah
Copy link
Member

The YAML files are in https://github.com/docker/docker.github.io/tree/master/_data/docker-app - ISTR we kept these docs up at the time, because the docker 20.10 linux packages still ship with the plugin (but added the "deprecated" options 6047b8f)

@usha-mandya
Copy link
Member Author

@thaJeztah Is Docker App still supported on 20.10 linux packages? I thought we've removed Docker App and we don't support it anymore. Could you please confirm?

@thaJeztah
Copy link
Member

It's still included, as we deprecated it during the 20.10 release (not "supported", as the project itself is marked deprecated, but we don't remove functionality in a patch release). It will be gone from the packages with the 22.xx release though (so: "soon")

@usha-mandya
Copy link
Member Author

Thanks @thaJeztah. We'll put this on hold now and merge it as part of Engine 22.x release

@docker-robott
Copy link
Collaborator

Thanks for the pull request. We'd like to make our product docs better, but haven’t been able to review all the suggestions.
As our docs have also diverged, we do not have the bandwidth to review and rebase old pull requests.

If the updates are still relevant, review our contribution guidelines and rebase your pull request against the latest version of the docs, then mark it as fresh with a /remove-lifecycle stale comment.
If not, this pull request will be closed in 30 days. This helps our maintainers focus on the active pull requests.

Prevent pull requests from auto-closing with a /lifecycle frozen comment.

/lifecycle stale

@thaJeztah
Copy link
Member

This will also be handled in #16416, so perhaps this one is fine to close (but we can check if there's things missing in that other PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/cli Relates to the CLI client lifecycle/stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants