-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Remove Docker app docs from the CLI reference #14492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@thaJeztah PTAL. Is there anything I should do in addition to removing the stubs and adding redirects? I don't see the generated yaml files in the repo. Guess these have already been removed. |
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Signed-off-by: Usha Mandya <usha.mandya@docker.com>
|
The YAML files are in https://github.com/docker/docker.github.io/tree/master/_data/docker-app - ISTR we kept these docs up at the time, because the docker 20.10 linux packages still ship with the plugin (but added the "deprecated" options 6047b8f) |
|
@thaJeztah Is Docker App still supported on 20.10 linux packages? I thought we've removed Docker App and we don't support it anymore. Could you please confirm? |
|
It's still included, as we deprecated it during the 20.10 release (not "supported", as the project itself is marked deprecated, but we don't remove functionality in a patch release). It will be gone from the packages with the 22.xx release though (so: "soon") |
|
Thanks @thaJeztah. We'll put this on hold now and merge it as part of Engine 22.x release |
|
Thanks for the pull request. We'd like to make our product docs better, but haven’t been able to review all the suggestions. If the updates are still relevant, review our contribution guidelines and rebase your pull request against the latest version of the docs, then mark it as fresh with a Prevent pull requests from auto-closing with a /lifecycle stale |
|
This will also be handled in #16416, so perhaps this one is fine to close (but we can check if there's things missing in that other PR) |
Signed-off-by: Usha Mandya usha.mandya@docker.com
Remove Docker app docs from the CLI reference