-
Notifications
You must be signed in to change notification settings - Fork 8.1k
jekyll: create plugin to update sitemap #14784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| Jekyll::Hooks.register :site, :post_write do |site| | ||
| beginning_time = Time.now | ||
| Jekyll.logger.info "Starting plugin update_sitemap.rb..." | ||
|
|
||
| sitemap_path = File.join(site.dest, 'sitemap.xml') | ||
| # DEPLOY_URL is from Netlify for preview of sitemap on PR | ||
| # https://docs.netlify.com/configure-builds/environment-variables/#deploy-urls-and-metadata | ||
| docs_url = ENV['DEPLOY_URL'] || ENV['DOCS_URL'] || 'http://localhost:4000' | ||
|
|
||
| if File.exist?(sitemap_path) | ||
| sitemap_file = File.read(sitemap_path) | ||
| replace = sitemap_file.gsub!("<loc>/", "<loc>#{docs_url}/") | ||
| Jekyll.logger.info " Replacing '<loc>/' with '<loc>#{docs_url}/' in #{sitemap_path}" | ||
| File.open(sitemap_path, "w") { |file| file.puts replace } | ||
| end | ||
|
|
||
| end_time = Time.now | ||
| Jekyll.logger.info "done in #{(end_time - beginning_time)} seconds" | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,6 +10,7 @@ services: | |
| build: | ||
| args: | ||
| - JEKYLL_ENV | ||
| - DOCS_URL | ||
| context: . | ||
| image: docs/docstage | ||
| ports: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <xsl:stylesheet version="2.0" | ||
| xmlns:xsl="http://www.w3.org/1999/XSL/Transform" | ||
| xmlns:sitemap="http://www.sitemaps.org/schemas/sitemap/0.9" | ||
| xmlns:image="http://www.google.com/schemas/sitemap-image/1.1" | ||
| xmlns:html="http://www.w3.org/TR/REC-html40"> | ||
| <xsl:output version="1.0" method="html" encoding="UTF-8" /> | ||
| <xsl:template match="/"> | ||
| <html xmlns="http://www.w3.org/1999/xhtml"> | ||
| <head> | ||
| <title>Docker Docs XML Sitemap</title> | ||
| <meta http-equiv="Content-Type" content="text/html; charset=utf-8" /> | ||
| <style type="text/css"> | ||
| html, body { | ||
| font-family: Arial, sans-serif; | ||
| font-size: 16px; | ||
| line-height: 1.0; | ||
| } | ||
| a { | ||
| color: #000; | ||
| } | ||
| .intro { | ||
| background-color: #CFEBF7; | ||
| border: 1px #2580B2 solid; | ||
| padding: 5px 13px 5px 13px; | ||
| margin: 10px; | ||
| width: 800px; | ||
| } | ||
| .intro p { | ||
| line-height: 0.5; | ||
| } | ||
| .list td, .list th { | ||
| padding: 5px; | ||
| font-size: 13px; | ||
| line-height: 1.5; | ||
| } | ||
| .list th { | ||
| text-align: left; | ||
| } | ||
| tr.high { | ||
| background-color: whitesmoke; | ||
| } | ||
| </style> | ||
| </head> | ||
| <body> | ||
| <h1>Docker Docs XML Sitemap</h1> | ||
| <div class="intro"> | ||
| <p>This is an XML Sitemap which is supposed to be processed by search engines like <a href="https://www.google.com">Google</a>, <a href="https://www.bing.com">Bing</a>, ...</p> | ||
| <p>You can find more information about XML sitemaps on <a href="https://sitemaps.org/">sitemaps.org</a> and Google's <a href="https://code.google.com/archive/p/sitemap-generators/wikis/SitemapGenerators.wiki">list of sitemap programs</a>.</p> | ||
| <p>This sitemap contains <strong><xsl:value-of select="count(sitemap:urlset/sitemap:url)"/></strong> URLs.</p> | ||
| </div> | ||
| <div id="content"> | ||
| <table class="list" cellpadding="5"> | ||
| <tr style="border-bottom:1px black solid;"> | ||
| <th>Location</th> | ||
| <th>Last Modification</th> | ||
| </tr> | ||
| <xsl:for-each select="sitemap:urlset/sitemap:url"> | ||
| <tr> | ||
| <xsl:if test="position() mod 2 != 1"> | ||
| <xsl:attribute name="class">high</xsl:attribute> | ||
| </xsl:if> | ||
| <td> | ||
| <xsl:variable name="itemURL"> | ||
| <xsl:value-of select="sitemap:loc"/> | ||
| </xsl:variable> | ||
| <a href="{$itemURL}"> | ||
| <xsl:value-of select="sitemap:loc"/> | ||
| </a> | ||
| </td> | ||
| <td> | ||
| <xsl:value-of select="concat(substring(sitemap:lastmod,0,11),concat(' ', substring(sitemap:lastmod,12,5)))"/> | ||
| </td> | ||
| </tr> | ||
| </xsl:for-each> | ||
| </table> | ||
| </div> | ||
| </body> | ||
| </html> | ||
| </xsl:template> | ||
| </xsl:stylesheet> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me check this one; I think the intent here was to remove some hard-coded URLs in the docs (e.g. from upstream MarkDown files) that have a full
https://docs.docker.com/URL in themURLs in the pages generated by Jekyll are expected to all be relative (so
<a href=/foo/bar/>, without a domain); the intent of that is so that the generated pages can be deployed to "any" domain (staging/local/elsewhere) without links going to the "live" domain.So perhaps that part was intentionally set to
docs.docker.comAs to the
sitemap.xmlhavingdocs.docker.comhard-coded; that may also have been intentional at the time, as we've had cases where Google found preview sites, and (although we setnoindexheaders), we wanted to avoid it finding thesitemap.xml, and as a result indexing those preview domains (and as a "best effort", we just pointed it to the live website, which was the "least bad" option.